Fix: CSP violations - inline script + SW network error - #20
Merged
Conversation
Three CSP-related fixes: 1. script-src 'unsafe-inline' added to CSP (vercel.json) Trunk 0.21 generates an inline script for WASM bootstrap whose content changes per build (content-hashed filenames). A static SHA-256 hash is non-viable. Documented in SECURITY.md. 2. Service worker network error handling (sw.js) The stale-while-revalidate handler now catches network failures and returns a 503 response instead of an unhandled TypeError. 3. CI csp-verify job updated to allow 'unsafe-inline' in script-src with an explanatory comment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CSP violations reported after Phase 7 deployment.
Changes
1.
vercel.json—script-src 'unsafe-inline'addedTrunk 0.21 generates an inline
<script type="module">to bootstrap WASM. The script content includes content-hashed filenames that change every build, making a static SHA-256 hash non-viable.unsafe-inlineis now accepted with a documented rationale.2.
static/pwa/sw.js— network error handlingThe stale-while-revalidate handler now catches network failures and returns a
503 Service Unavailableresponse instead of letting the promise reject with an unhandledTypeError: Failed to fetch.3.
.github/workflows/ci.yml— CI updatedThe
csp-verifyjob now allowsunsafe-inlineinscript-srcwith an explanatory comment (was: hard-fail).4.
SECURITY.md— known limitation documentedCSP section updated to reflect the
unsafe-inlinetradeoff and why a static hash doesn't work with Trunk's build output.