Repository navigation
feat: hide model change markers by default with a Timeline setting (ADR 24) - #90
Merged
Merged
Conversation
Model change markers are hidden unless Show model changes is turned on in the new Timeline tab. The setting is a Paseo host settings document that the server follows through registerSettings(), so the minimum Paseo is now 0.9.0 (ADR 23). Whether a marker is shown is decided when it is first seen.
Renumber the timeline settings ADR to 24, since main added ADR 23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Paseo timeline showed ZCode's model change markers as
Model: GLM-5.3-Flash (). The text in parentheses is the marker's reasoning level, and ZCode leaves it empty when the selection has none. The line showed only the target model ID, so a reader could not tell which provider ran the turn or what it changed from. In #83 these lines also piled up on every turn and buried the conversation.Change
Using magpie/GLM-5.3-Flashfor a marker with no previous model, andModel switched magpie/GLM-5.3-Flash → magpie/auto/glm-5.3-flashfor a switch. It shows provider IDs, because the marker carries no display names. The reasoning level is no longer shown: Desktop omits it too, and ZCode does not count a reasoning level change as a model change.timeline,shared/timeline.ts). The server follows it through theregisterSettings()handle. The defaults apply until the first read completes and while the stored document is invalid. The tab can reset an invalid document.registerSettings()returns no handle, so the server could not read the switch there.paseo-plugin.jsonnow requires>=0.9.0. ADR 24 records the decision and amends ADR 8, which had ruled out saving settings.server/presentation.test.tscovers both marker forms, including an empty reasoning level.test/provider.test.tschecks that the setting applies when a marker is first seen and that a reopened session follows the current setting. Both fail without the change.server/timeline-settings.test.tscovers the defaults, saved values, invalid documents and a save that arrives before the first read.test:upstreamnow gives its mock contextregisterSettingsand checks that the plugin registers the document.Related issue
Refs #83. This fixes the empty parentheses and hides the lines by default. The lines repeating on every turn did not reproduce locally, and questions are pending on the issue.
Verification (Linux x64, Node.js 26.8.1)
auto/glm-5.3-flash, I ran turns before and after closing and resuming the session twice, with and without a subagent. No model change markers appeared, and every request usedauto/glm-5.3-flashwithmax.npm run typecheck,npm test(24 files, 233 tests, after merging fix: report why a ZCode turn failed #91 frommain),npm run format:check,npm run build,git diff --checkandadrs doctorpassed. The only doctor warning was already reported for ADR 1.npm run test:upstreamagainst Paseo 0.12.0 (cafe4b01c8522ff39560241c5deb01427dc8dc5b) passed, including the settings registration.@getpaseo/cli@0.15.1daemon (temporary home, loopback, relay and MCP off, web UI and plugins on) and opened Settings → Plugins → zcode-provider → Settings → Timeline in headless Chrome. The switch was off by default. Turning it on saved{"showModelChanges":true}toplugin-settings/zcode-provider/timeline.json, and the value survived a reload.Screenshots
Timeline tab on the temporary Paseo 0.15.1 daemon, with the default (off) and after turning the switch on.
Not verified
test:upstreamwith the real compiler of the new minimum, Paseo 0.9.0.