Conversation
supermihi
approved these changes
Jun 18, 2021
Owner
supermihi
left a comment
supermihi
left a comment
There was a problem hiding this comment.
Thanks. Bonus achievement: add some tests 😀 😝
|
|
||
|
|
||
| enum TrickEvent { | ||
| FOXCAUGHT = 0; |
Owner
There was a problem hiding this comment.
I'd prefer sepating words by underscores (in line with the style guide):
FOX_CAUGHT
DOPPELKOPF_SCORED
...
|
|
||
| func fuechse(g *game.Game) []ExtraPoint { | ||
| //logic without party information | ||
| func maybeFoxCaught(player game.Player, trick *game.Trick) bool { |
Owner
There was a problem hiding this comment.
note: in the doppelkopf app I use regularly, party information is consirede public once a player has played a queen of clubs, which is then used to emit the „fox caught“ event more precisely. However in real games it is not uncommon to forget who played a »Dulle«, I think this should also be possibility in the app. ;-)
But at least when contra/re etc. are announced that information could be used (in a separate PR, of course) to add constraints to this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a message for scored (or possible scored) extrapoint