fix(launch): use forward slashes in generated .dockerignore#4883
Open
fix(launch): use forward slashes in generated .dockerignore#4883
Conversation
On Windows, `fly launch` was writing dockerignore patterns with backslashes (e.g. `**\*.db`) because both `filepath.Rel` and `filepath.Join` return OS-native separators. Local CLI deploys still worked, but `superfly/flyctl-actions` (which runs on Linux) failed with `syntax error in pattern`. Normalize relDir/relFile with `filepath.ToSlash` after the `filepath.Rel` calls, and switch the four pattern joins to `path.Join` (which always uses `/`). No behavior change on Mac/Linux — `filepath.ToSlash` is a no-op when the OS separator is already `/`. Fixes #4727
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4727
On Windows,
fly launchwas writing dockerignore patterns with backslashes (e.g.**\*.db) because bothfilepath.Relandfilepath.Joinreturn OS-native separators. Local CLI deploys still worked, butsuperfly/flyctl-actions(which runs on Linux) failed withsyntax error in pattern.Normalize relDir/relFile with
filepath.ToSlashafter thefilepath.Relcalls, and switch the four pattern joins topath.Join(which always uses/). No behavior change on Mac/Linux —filepath.ToSlashis a no-op when the OS separator is already/.