fix: detect machine update reverts during deploy#4878
Draft
rianmcguirefly wants to merge 1 commit intomasterfrom
Draft
fix: detect machine update reverts during deploy#4878rianmcguirefly wants to merge 1 commit intomasterfrom
rianmcguirefly wants to merge 1 commit intomasterfrom
Conversation
Previously, when Flaps gave up on an update and reverted a machine to its previous version, flyctl saw the machine in the "started" state (the old version still running) and treated the deploy as successful. Health checks would pass against the old image, so users had no indication their new code wasn't deployed. Pass the post-update InstanceID to flaps Wait via WithWaitVersion so Flaps signals success only when that specific version reaches the desired state. A reverted update will now correctly time out instead of silently succeeding. Affects both `flyctl deploy` (in-place updates) and standalone `flyctl machine update`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Previously, when Flaps gave up on an update and reverted a machine to its previous version, flyctl saw the machine in the "started" state (the old version still running) and treated the deploy as successful. Health checks would pass against the old image, so users had no indication their new code wasn't deployed.
Affects both
flyctl deploy(in-place updates) and standaloneflyctl machine update.How:
Pass the post-update InstanceID to flaps Wait via WithWaitVersion so Flaps signals success only when that specific version reaches the desired state. A reverted update will now correctly time out instead of silently succeeding.
Related to:
Documentation