fix: scope statics addon lookup by org#4870
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR scopes the statics (Tigris) add-on/bucket lookup to the application’s organization by switching from a global add-ons listing to an organization-scoped GraphQL query, and updates the associated Go types/bindings.
Changes:
- Replace global
ListAddOnscalls withListOrganizationAddOns(orgSlug, type)for statics bucket discovery. - Update statics add-on types to use a new
gql.StaticsAddOnalias. - Regenerate GraphQL client bindings to include the new query.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/command/deploy/statics/move.go | Updates MoveBucket to accept the new statics add-on alias type. |
| internal/command/deploy/statics/addon.go | Uses organization-scoped add-on listing for statics bucket lookup. |
| gql/types.go | Adds StaticsAddOn type alias for the org-scoped query node type. |
| gql/genqclient.graphql | Introduces ListOrganizationAddOns query. |
| gql/generated.go | Regenerates genqlient bindings to include the new query/types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing