Skip to content

fix: scope statics addon lookup by org#4870

Merged
dangra merged 3 commits intomasterfrom
fix/apps-destroy-org-scoped-addons
Apr 28, 2026
Merged

fix: scope statics addon lookup by org#4870
dangra merged 3 commits intomasterfrom
fix/apps-destroy-org-scoped-addons

Conversation

@dangra
Copy link
Copy Markdown
Member

@dangra dangra commented Apr 28, 2026

Summary

  • scope statics bucket lookup to the app organization
  • use an organization-scoped addons query instead of listing all Tigris addons
  • regenerate GraphQL bindings and update statics addon type alias

Testing

  • go test ./internal/command/apps ./internal/command/deploy/statics ./internal/command/extensions/core

Copilot AI review requested due to automatic review settings April 28, 2026 17:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR scopes the statics (Tigris) add-on/bucket lookup to the application’s organization by switching from a global add-ons listing to an organization-scoped GraphQL query, and updates the associated Go types/bindings.

Changes:

  • Replace global ListAddOns calls with ListOrganizationAddOns(orgSlug, type) for statics bucket discovery.
  • Update statics add-on types to use a new gql.StaticsAddOn alias.
  • Regenerate GraphQL client bindings to include the new query.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/command/deploy/statics/move.go Updates MoveBucket to accept the new statics add-on alias type.
internal/command/deploy/statics/addon.go Uses organization-scoped add-on listing for statics bucket lookup.
gql/types.go Adds StaticsAddOn type alias for the org-scoped query node type.
gql/genqclient.graphql Introduces ListOrganizationAddOns query.
gql/generated.go Regenerates genqlient bindings to include the new query/types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/command/deploy/statics/addon.go Outdated
@dangra dangra merged commit 47cecad into master Apr 28, 2026
24 checks passed
@dangra dangra deleted the fix/apps-destroy-org-scoped-addons branch April 28, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants