refactor: use Flaps DeleteApp for app deletion#4869
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors application deletion to use the Flaps client’s DeleteApp instead of the API client, aligning destructive app operations with the Machines/Flaps pathway and updating related builder cleanup logic.
Changes:
- Switch
apps destroyto delete apps viaflapsutil.ClientFromContext(ctx).DeleteApp. - Update remote builder cleanup paths to delete builder apps via Flaps.
- Make the mock Flaps client’s
DeleteApphandler nil-safe to avoid test panics when unset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/mock/flaps_client.go | Makes DeleteApp a no-op when DeleteAppFunc isn’t provided, improving test robustness. |
| internal/command/apps/destroy.go | Uses Flaps DeleteApp for app destruction while retaining API client usage for lookups/add-on cleanup. |
| internal/build/imgsrc/ensure_builder.go | Switches builder-app deletion/cleanup to Flaps DeleteApp, including error-path cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteAppto FlapsDeleteAppDeleteAppnil-safe for testsTesting