Skip to content

typo correction #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prko wants to merge 3 commits into
base: main
Choose a base branch
from
Open

typo correction #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cbfd69
typo correction
prko Jun 11, 2026
b6e52d0
Update BMoog.schelp
prko Jun 11, 2026
595b64a
Update BMoog.schelp
prko Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions source/BlackrainUGens/sc/HelpSource/Classes/BMoog.schelp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ table::
::
defaults to lowpass.

argument::saturation

@dyfer dyfer Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for this change, I don't think we need the rest of this PR anymore, since the help browser code selection was fixed, what do you think?

@prko prko Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don’t think so. Please see my comments on each change.


Examples::

Expand All @@ -44,7 +45,8 @@ z = {
MouseY.kr(1.0, 0.0, \linear), // q
0, // mode - lowpass
0.25); // mul
}.play)
}.play
)

@prko prko Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR corrects the incorrect placement of a closing parenthesis.

@dyfer dyfer Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but that's just cosmetic. It should work either way. But if you'd like, we can indeed change it.

@prko prko Jul 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an official document should not contain any oddities.

z.release;

(
Expand All @@ -57,7 +59,8 @@ z = {
MouseY.kr(1,0,\linear),
0); // filter mode - lowpass
(CombN.ar(sig, 0.4, [0.4,0.35],2) * 0.4) + (sig * 0.5);
}.play)
}.play
)

@prko prko Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR corrects the incorrect placement of a closing parenthesis.

z.release

(
Expand All @@ -70,7 +73,8 @@ z = {
MouseY.kr(1,0,\linear),
1); // filter mode - highpass
(CombN.ar(sig, 0.4, [0.4,0.35],2) * 0.4) + (sig * 0.5);
}.play)
}.play
)

@prko prko Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR corrects the incorrect placement of a closing parenthesis.

z.release

(
Expand All @@ -83,7 +87,8 @@ z = {
MouseY.kr(1,0,\linear),
2); // filter mode - bandpass
(CombN.ar(sig, 0.4, [0.4,0.35],2) * 0.4) + (sig * 0.5);
}.play)
}.play
)

@prko prko Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR corrects the incorrect placement of a closing parenthesis.

z.release

(
Expand All @@ -96,10 +101,11 @@ z = {
MouseY.kr(1,0,\linear),
LFSaw.kr(1,0,3)); // filter mode - sweep modes
(CombN.ar(sig, 0.4, [0.4,0.35],2) * 0.4) + (sig * 0.5);
}.play)
}.play
)

@prko prko Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR corrects the incorrect placement of a closing parenthesis.

z.release

// bhob's benchmark ;)
// bhob's benchmark

@prko prko Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be preserved now.

(
z = {
var sig;
Expand Down
2 changes: 1 addition & 1 deletion source/NCAnalysisUGens/sc/HelpSource/Classes/LPCAnalyzer.schelp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ LPCAnalyzer.ar(input,source, 64,MouseX.kr(1,64), windowtype:1)

//////////////////////////////////////

//residual test assumes windowtype 0)
//residual test assumes windowtype 0:
Comment thread
prko marked this conversation as resolved.
(
{
var input,source;
Expand Down