fix: dismissed PR findings resurfacing after new commits#25
Merged
Conversation
homanp
changed the title
Contributor License AgreementAll contributors are covered by a CLA. |
superagent-security
Bot
added
contributor:verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dismissed PR findings were resurfacing after follow-up commits because fingerprint dismissal lookups required an exact
head_shamatch. When a PR was rescanned on a new commit, previously dismissed findings with the same fingerprint were treated as open again.This change keeps dismissal records scoped to the PR and finding fingerprint, while still storing
head_shafor audit purposes. Rescans now suppress findings that were already dismissed or resolved on earlier commits.Fixes #
Checklist