Skip to content

fix: Superagent links in check runs and comments#23

Merged
homanp merged 8 commits into
mainfrom
fix/check-run-superagent-url
May 25, 2026
Merged

fix: Superagent links in check runs and comments#23
homanp merged 8 commits into
mainfrom
fix/check-run-superagent-url

Conversation

@homanp
Copy link
Copy Markdown
Contributor

@homanp homanp commented May 25, 2026

What does this PR do?

Updates Superagent branding links so PR checks and comments point to superagent.sh instead of brin.sh.

  • Comment footers link to https://superagent.sh instead of https://brin.sh
  • Removes the external contributor profile link from trust check comments

Fixes #20

Checklist

  • I tested my changes
  • I reviewed my own code

Set check run details_url to superagent.sh and remove the external contributor profile link from trust comments.
@homanp homanp changed the base branch from homanp/brin-github-app to main May 25, 2026 07:37
@homanp homanp changed the title Fix Superagent links in check runs and comments fix: Superagent links in check runs and comments May 25, 2026
@homanp homanp marked this pull request as ready for review May 25, 2026 07:38
@homanp homanp self-assigned this May 25, 2026
@open-cla
Copy link
Copy Markdown

open-cla Bot commented May 25, 2026

Contributor License Agreement

All contributors are covered by a CLA.

@superagent-security superagent-security Bot added contributor:verified Contributor passed trust analysis. pr:verified PR passed security analysis. labels May 25, 2026
Track dismissed findings by stable fingerprint so accepted or resolved scanner comments are not recreated on later commits.
@superagent-security superagent-security Bot added pr:flagged PR flagged for review by security analysis. and removed pr:verified PR passed security analysis. labels May 25, 2026
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

Rehydrate reviewed findings for the active head before suppressing scanner comments so stale fingerprints do not suppress unrelated future findings.
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 2 security concern(s).

@homanp
Copy link
Copy Markdown
Contributor Author

homanp commented May 25, 2026

@cursor review

Trust acknowledgment markers only from bot-authored replies and bind reviewed finding dismissals to the review comment commit SHA.
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1b90698. Configure here.

Only trust hidden acknowledgment markers from the Superagent bot identity so other bots cannot suppress scanner findings.
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

Ignore marker-bearing review comments unless they were authored by the Superagent bot before using them for dismissal matching.
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

Use the root finding review comment commit when storing dismissal fingerprints so stale comments are not bound to the current PR head.
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

@superagent-security superagent-security Bot added pr:verified PR passed security analysis. and removed pr:flagged PR flagged for review by security analysis. labels May 25, 2026
Allow the local dev GitHub App identity when matching Superagent-authored finding and acknowledgment comments.
@superagent-security superagent-security Bot added pr:flagged PR flagged for review by security analysis. and removed pr:verified PR passed security analysis. labels May 25, 2026
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

Comment thread src/services/findingDismissal.ts
@superagent-security superagent-security Bot added pr:verified PR passed security analysis. and removed pr:flagged PR flagged for review by security analysis. labels May 25, 2026
@homanp homanp merged commit bb7200d into main May 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:verified Contributor passed trust analysis. pr:verified PR passed security analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Actions link to Brin.sh

1 participant