Make the terminal find bar transparent over the window chrome - #822
Merged
Conversation
The docked find bar drew an opaque bar material and a solid text-field fill, so it read as a white slab instead of letting the window tint and blur show through like the tab strip above it. Drop the bar background, fill the field with the quaternary style, and align the field height, font, and magnifier scale with the bar's small controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The per-tab find bar introduced in #819 drew an opaque bar material plus a solid text-field fill, so it rendered as a white slab instead of letting the window tint and blur shine through like the rest of the tab chrome. This drops the bar background, fills the search field with the quaternary style, and aligns the field height, font, and magnifier scale with the bar's small controls.
Type of change
ready)How was this tested?
Built and ran the app, opened the find bar over a tinted worktree window, and confirmed the chrome background shows through with all controls sitting level.
make checkpasses (format + lint)make testpassesChecklist
Closes #above.ready.