Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
After a push times out,
AsyncPush.resend()sends it again but does not schedule another timeout because the completed task is still stored intimeout_task. For channel join retries, a second unacknowledged join can therefore leave the channel waiting indefinitely.Solution
Release the timeout task reference when the timer fires so
resend()can arm a new timer. This keeps cancellation behavior and the public API unchanged.Tests
uv run --package realtime pytest src/realtime/tests/test_push.py src/realtime/tests/test_timer.py -q— 7 passedmake realtime.tests— mypy passed; 32 tests passed against the local Supabase stackuv run ruff check src/realtime— passeduv run ruff format --check src/realtime— passeduv build --package realtime— passedgit diff --check— passedCloses #1653
@olirice @silentworks