Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nonefrom vector bucket and index lookups only for HTTP 404 responsesStorageApiErrorProblem
get_bucket()andget_index()caught everyStorageApiError, so a service failure such as HTTP 500 was indistinguishable from a missing resource.Solution
Keep the existing optional-result behavior for HTTP 404, and re-raise every other API error. The sync implementation and tests are generated from the async source.
Tests
mainbecause noStorageApiErrorwas raiseduv run --package storage3 pytest -o addopts= src/storage/tests/_async/test_vectors.py src/storage/tests/_sync/test_vectors.py -q— 6 passedmake testsinsrc/storage— 122 passed; mypy passeduv run ruff check src/storage— passeduv run ruff format --check src/storage— 36 files already formatteduv build --package storage3— source distribution and wheel built successfullygit diff --check— passedFixes #1649
cc @olirice @silentworks