Conversation
AsyncPush.send() built outgoing Messages with only `ref`, leaving `join_ref` permanently null. The Realtime protocol requires join_ref on every client-sent event (join, leave, broadcast, presence track/untrack) so the server can detect stale messages after a rejoin; newer Phoenix versions rely on it and silently drop pushes that omit it (matches the track/untrack timeout reports in SDK-1526). Fixes SDK-1526
Contributor
|
The following capabilities are marked
The following capabilities are marked
These may have been renamed, removed, or never registered. Please update the capability matrix. |
Tr00d
approved these changes
Sep 10, 2026
spydon
approved these changes
Sep 10, 2026
grdsdev
deleted the
guilhermesouza/sdk-1526-check-join_ref-handling-in-python-realtime-sdk
branch
September 17, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncPush.send()built outgoingMessages with onlyref, leavingjoin_refpermanentlynull. The Realtime protocol requiresjoin_refon every client-sent event (join, leave, broadcast, presence track/untrack) so the server can detect stale messages after a rejoin; newer Phoenix versions rely on it and silently drop pushes that omit it — this matches the track/untrack timeout reports that motivated this check.Fix:
AsyncPush.send()now setsjoin_ref=self.channel.join_push.refwhen building the outgoing message.Test plan
tests/test_join_ref.py(5 tests): join carriesjoin_ref == ref, broadcast/track/untrack carry the channel'sjoin_ref, leave carries the pre-leavejoin_ref, rejoin produces a freshjoin_ref.ruff check/ruff format --check: clean.mypy src/realtime tests: clean.pytest tests/: 25 passed, 6 failed — the 6 failures need a local Supabase stack (127.0.0.1:54321) and fail identically onmain, unrelated to this change.Fixes SDK-1526