Conversation
…branching - Add .clone() to RequestConfig and BaseFilterRequestBuilder deep-copying headers, params, and json - Add .clone() to AsyncRequestBuilder, AsyncQueryRequestBuilder, AsyncSingleRequestBuilder, AsyncExplainRequestBuilder, AsyncMaybeSingleRequestBuilder - Generate sync counterparts via run-unasync.py - Add unit tests for filter and query builder clone isolation and branching Fixes supabase#1208 Ref: supabase/supabase#50049
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements explicit
.clone()method across PostgREST query and filter request builders for safe query branching without in-place mutation.Motivation
As discussed in supabase/supabase#50049 and issue #1208, builders mutate internal state in-place.
.clone()provides an ergonomic way to branch queries (pagination, total counts, dynamic filtering) without breaking backwards compatibility.Changes
.clone()toRequestConfigandBaseFilterRequestBuilder(deep-copies headers, params, JSON payloads)..clone()to all async and sync request builders.Fixes #1208
Ref: supabase/supabase#50049