fix(postgrest): preserve text search negation - #1624
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not_.text_search()now negates the full-text search and consumes the pending negation flag. For example, plain English search producesnot.plfts(english).fat cat; previously it producedplfts(english).fat catand could negate a later filter instead.Fixes #1623.
Related: #1616, #1619. The
or_()change is separate from this text-search path.Validation from
src/postgrest:pytest tests --ignore=tests/_async/test_filter_request_builder_integration.py --ignore=tests/_sync/test_filter_request_builder_integration.py -q— 234 passed. The 32 sync/async regression cases cover all search modes, optional configuration, positive/negative searches and a subsequent filter; eight async cases fail before the fix. Ruff passes on the four changed files, andmypy src/postgrest testspasses. Live PostgREST integration tests were not run because no database service was started.The async and sync changes match; existing unrelated drift in the sync generation output was excluded. No service deployment or new monitoring is needed for this query-construction fix.
Review requested: @olirice @silentworks, per the contribution guide.
Agent-assisted: Codex prepared the patch and ran the local checks listed above.