Repository navigation
Conversation
Tr00d
reviewed
Sep 30, 2026
Tr00d
left a comment
Tr00d
left a comment
Contributor
There was a problem hiding this comment.
I would wait on this one, depending on what happens with #460
The reason is we're duplicating the logic from ParseJsonBody between packages, under Helpers.cs
If this is meant to be reused, we should probably move it to Core instead. The only difference is the target exception, which we can delegate with a function
Contributor
Author
|
closing this for now, the storage fix will come with the shared helper refactor after #459 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a 2xx body that isn't JSON, like a proxy's html error page, now throws a SupabaseStorageException instead of a JsonException, same as storage-js. its message is the parse error, not the body, since storage responses can carry signed urls. storage side of #260, fixed for postgrest in #459.