Adding forward-compatibility for sphinx 9. #314
Conversation
|
Can you please fix the CI? |
src/ablog/blog.py
Outdated
| return self.docwriter.parts["fragment"] | ||
|
|
||
| try: | ||
| # sphinx >= 9 |
There was a problem hiding this comment.
You can test sphinx.version_info[0] >= 9 here.
There was a problem hiding this comment.
done, thanks.
Signed-off-by: Daniel Baumann <daniel@debian.org>
|
Hi @nabobalis, can you please merge this when you are free? B.T.W. I heavily use this extension; Perhaps I could become a member of the maintainers and help handle issues and pull requests. |
|
Hello @SilverRainZ, I have stepped back from maintain projects under the sunpy umbrella as a result, I lack any write access to this repository anymore. Hopefully someone from the @sunpy/sunpy-core-team will be able to review and merge this PR. Thank you @daniel-baumann for opening the PR as well. |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
hey @daniel-baumann thanks a lot for this PR, the notifications got lost in the post holiday chaos. I'll have a look at it now. |
|
The CI is very broken, but that doesn't seem to be the fault of this PR. I'll merge this then try and fix up the CI when I can before cutting a release. |
4 participants
Hi,
with sphinx 9.x, ablog doesn't work (see #313).
This commit fixes it by first trying the new code for sphinx 9.x, but keeping the legacy compatiblity for sphinx 8 in place as fallback.
Please consider merging it.
Regards,
Daniel