Open
Conversation
runScript() spawns Node with '--import tsx' but did not set cwd, causing tsx resolution to fail when npx openutter is run from a directory without tsx in its node_modules. Other spawn helpers (runNodeCommand, runPlaywrightCommand) already set cwd: pkgRoot. This aligns runScript with that pattern. Fixes sumansid#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Problem
npx openutter joinfails withERR_MODULE_NOT_FOUND: Cannot find package 'tsx'when run from any directory that does not havetsxin itsnode_modules.Root Cause
runScript()spawns Node with--import tsxbut does not setcwd: pkgRoot. Node resolvestsxrelative to the current working directory instead of the package root wheretsxis actually installed.Fix
One-line change: add
cwd: pkgRootto thespawnSyncoptions inrunScript(), consistent withrunNodeCommand()andrunPlaywrightCommand()which already set this.Testing
Before fix:
After fix: