Skip to content

Refactor CMakeLists #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukeya merged 3 commits into from
Jan 18, 2026
Merged

Refactor CMakeLists #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9589778
Make CMAKE_EXPORT_COMPILE_COMMANDS off.
sukeya Jan 18, 2026
c2183a6
Rename "local" preset.
sukeya Jan 18, 2026
2df17b0
Add -Werror for gcc and clang and /WX for msvc.
sukeya Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ target_link_libraries(
${extra_libs}
)

set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
set(gcc "$<COMPILE_LANG_AND_ID:CXX,GNU>")
set(clang "$<COMPILE_LANG_AND_ID:CXX,Clang>")
set(msvc "$<COMPILE_LANG_AND_ID:CXX,MSVC>")
Expand Down
2 changes: 1 addition & 1 deletion CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"generator": "Ninja"
},
{
"name": "local",
"name": "test_local",
"inherits": ["test"],
"cacheVariables": {
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON"
Expand Down
4 changes: 2 additions & 2 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ target_compile_options(
mvPolynomial_test
INTERFACE
# Common options for gcc and clang
"$<${gcc_like}>:-Wall;-Wextra>"
"$<${msvc}:/Wall>"
"$<${gcc_like}:-Wall;-Wextra;-Werror>"
"$<${msvc}:/Wall;/WX>"
)
target_link_libraries(
mvPolynomial_test
Expand Down