Development - #768
Draft
jbpenrath wants to merge 5 commits into
Draft
Conversation
jbpenrath
marked this pull request as draft
July 29, 2026 11:34
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughInbound and imported messages now use a unified thread resolver. ChangesInbound threading
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SMTPClient
participant InboundMTA
participant MessageCreation
participant ThreadResolver
participant Mailbox
SMTPClient->>InboundMTA: deliver email
InboundMTA->>MessageCreation: parse inbound message
MessageCreation->>ThreadResolver: find_thread_for_message
ThreadResolver->>Mailbox: query In-Reply-To and References parents
Mailbox-->>ThreadResolver: matching parent messages
ThreadResolver-->>MessageCreation: matching thread or None
MessageCreation-->>InboundMTA: create message in selected thread
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jbpenrath
changed the title
A reply carrying In-Reply-To to a message we already hold was still rejected when its subject differed, because the delivery path required both a reference match and an identical canonical subject. A subject edited mid-conversation therefore started a brand new thread. The import path had its own laxer rule (message-ids only), so the very same conversation was grouped differently depending on whether it was imported or received over SMTP. Both paths now share find_thread_for_message: In-Reply-To is trusted on its own (RFC 8621 §3 only allows splitting on subject, never requires it), while References — which some clients recycle to start unrelated topics — still needs a matching canonical subject. The canonicalization also accepts "Re:subject" with no space, common on mobile clients.
Currently when a user paste content into the composer, if this one has text or background color, this is preserved as is then export into the output. Now only color supported by blocknote are preserved and exported. We also apply this sanitization to table elements. Furthermore, we also drop unsupported blocks (file, audio, video) and fix a bug that prevent to embed external images.
Use the new preview_text method of jmap_email to generate clean snippet for thread (denormalized at update_stats) and message (at serialization). Now when a mesage is folded, we display this snippet. In the thread list we also display this snippet above the subject.
Put app name as suffix not prefix of the page title. Align all document title accross the app. Mailbox Name - Folder Name - App Name
Do not fetch stats for sent folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Intermediate branch
Summary by CodeRabbit
In-Reply-Toheaders now remain in the original conversation even when the subject changes.Referencesare matched more accurately, preventing unrelated messages from being grouped together.