fix: widen symbol target candidate sources in output window - #489
Merged
sudo-tee merged 3 commits intoSep 10, 2026
Merged
Conversation
jensenojs
force-pushed
the
fix/symbol-target-candidate-sources
branch
from
September 10, 2026 03:15
93c5f89 to
6ed7b8e
Compare
jensenojs
force-pushed
the
fix/symbol-target-candidate-sources
branch
from
September 10, 2026 03:28
d88ff87 to
5943344
Compare
jensenojs
marked this pull request as ready for review
September 10, 2026 03:53
Collaborator
Author
|
I'm back! @sudo-tee |
Owner
|
Thanks for the PR, this looks like a nice fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol jump in the output window often missed because the candidate file set was too narrow: files @-mentioned in user messages were dropped, bare-name mentions failed the cwd-relative readability check, and the formatter only accepted files mentioned before the token.
Now
reference_facts.available_files()unions readable ref files with loaded plain buffers, user file parts enter reference facts, the position narrowing is gone, and navigation re-reads the set at keypress time.gdis also bound tojump_to_target_at_cursorin the output window.Full suite passes; added an e2e regression covering open-buffer-as-only-candidate.