feat(equipment): add DPV as an equipment type (closes #806) - #952
Open
etlami wants to merge 1 commit into
Open
Conversation
Contributor
|
📦 Build artifacts for this PR · commit
Artifacts expire in 7 days. Downloading requires being signed in to GitHub. macOS needs two extractions: unzip the downloaded artifact, then unzip the Updated automatically on each push. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for DPV (diver propulsion vehicle / scooter) as a first-class EquipmentType, ensuring it appears in existing equipment-type pickers and has a consistent icon and localization key across all supported locales.
Changes:
- Added
EquipmentType.dpvto the coreEquipmentTypeenum. - Mapped
EquipmentType.dpvtoIcons.electric_scooterin the two equipment-type icon pickers. - Added
enum_equipmentType_dpvto all locale ARB files and regeneratedAppLocalizationsoutputs.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/core/constants/enums.dart | Adds EquipmentType.dpv. |
| lib/features/dive_log/presentation/widgets/pickers/equipment_picker_sheet.dart | Adds DPV icon mapping in picker. |
| lib/features/dive_log/presentation/pages/dive_edit_page.dart | Adds DPV icon mapping in edit page picker. |
| lib/l10n/arb/app_en.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_ar.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_de.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_es.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_fr.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_he.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_hu.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_it.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_nl.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_pt.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_zh.arb | Adds enum_equipmentType_dpv string. |
| lib/l10n/arb/app_localizations.dart | Adds abstract getter for DPV localization key. |
| lib/l10n/arb/app_localizations_en.dart | Adds English DPV localization getter. |
| lib/l10n/arb/app_localizations_ar.dart | Adds Arabic DPV localization getter. |
| lib/l10n/arb/app_localizations_de.dart | Adds German DPV localization getter. |
| lib/l10n/arb/app_localizations_es.dart | Adds Spanish DPV localization getter. |
| lib/l10n/arb/app_localizations_fr.dart | Adds French DPV localization getter. |
| lib/l10n/arb/app_localizations_he.dart | Adds Hebrew DPV localization getter. |
| lib/l10n/arb/app_localizations_hu.dart | Adds Hungarian DPV localization getter. |
| lib/l10n/arb/app_localizations_it.dart | Adds Italian DPV localization getter. |
| lib/l10n/arb/app_localizations_nl.dart | Adds Dutch DPV localization getter. |
| lib/l10n/arb/app_localizations_pt.dart | Adds Portuguese DPV localization getter. |
| lib/l10n/arb/app_localizations_zh.dart | Adds Chinese DPV localization getter. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Requested in submersion-app#806 (as "Scooter"). Uses the standard term DPV (diver propulsion vehicle) for the type name; a scooter icon represents it in the type pickers. Stored by enum name, so no migration is needed and existing data is unaffected. Adds the enum value, the two equipment-type icon switches, and the enum_equipmentType_dpv localization across all locales. Closes submersion-app#806
etlami
force-pushed
the
feat/equipment-type-dpv
branch
from
August 11, 2026 06:21
a48cbb4 to
db27474
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #806 — being able to track equipment of type "Scooter". Implemented using the standard term DPV (diver propulsion vehicle) for the type name.
EquipmentType.dpv(display name DPV).Icons.electric_scooter) in the two equipment-type icon pickers.enum_equipmentType_dpvlocalization added across all eleven locales (kept as the abbreviation "DPV", like BCD/SMB).Notes
otherfor unknown values, so this needs no migration and doesn't affect existing data.EquipmentType.values, so DPV appears automatically; the two exhaustive icon switches are the only code that needed the new case.Verified locally (Flutter 3.44.8 / Dart 3.12.2):
flutter analyze libandflutter analyze testclean,dart formatclean,flutter gen-l10nrun, equipment / equipment-picker / arb-parity suites green. (One unrelated pre-existing date-dependent flake inservice_schedule_repository_test—2026vs2025— is untouched by this change.)