Playlist downloads, artist downloads, session activity combined PR - #7
Draft
wsturgiss wants to merge 14 commits into
Draft
Playlist downloads, artist downloads, session activity combined PR#7wsturgiss wants to merge 14 commits into
wsturgiss wants to merge 14 commits into
Conversation
Mirrors the existing 'Download Album' behavior in AlbumActionsScreen: shows 'Download Playlist' when tracks aren't fully downloaded, or 'Remove from Downloads' when they are, gated on source.supportsDownloads.
PlexLinkScreen always minted a fresh MusicSource.id when linking or re-linking a server, and AppSettings.saveSource only matched existing sources by that id. Re-linking the same Plex server from a different network (a different address winning the reachability check) silently added a second Sources entry for it. saveSource now also matches an existing source by (kind, machineIdentifier) when the id doesn't match anything, and if found, keeps the original id and merges in its existing download/offline-mode preferences rather than creating a duplicate. saveSource now returns the effective id so callers that immediately set the active source use the right one.
Mirrors the existing 'Download Album' behavior in AlbumActionsScreen: downloads every track across an artist's discography, or offers to remove them if already fully downloaded.
wsturgiss
marked this pull request as draft
August 13, 2026 16:45
Author
|
This is the branch I am using that combines all the other feature branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.