included package locks in gitignore#57
Open
VedantAnand17 wants to merge 4 commits into
Open
Conversation
…sed messages for improved hero alignment, readability, and context
…phrases (subh05sus#49) # 🚀 Pull Request Overview ## 📄 Description This PR updates the hero section’s rotating text: - Fixed alignment issues where descenders (e.g., "g" in "strong") were clipped - Adjusted vertical spacing for better readability - Expanded the rotating text set with developer/community-focused messages⚠️ Issue is not fully resolved — further refinements will follow in upcoming commits. ## 🔗 Related Issue(s) Related to subh05sus#31 ## 🛠️ Changes Made - Fixed clipping and alignment in `TextRotation.tsx` - Improved hero text vertical balance - Added developer-oriented rotating messages (e.g., *with developers.*, *that inspire.*, *through code.*) ## 🧪 Testing Details - [x] Ran `npm run dev` without errors - [x] Verified no clipping in rotating text - [x] Checked readability in dark/light mode ## 📸 Screenshots (if UI changes) <img width="1913" height="907" alt="image_2025-09-03_171626857" src="https://github.com/user-attachments/assets/2856ea56-07d7-4d49-becb-76bc86c31b49" /> ## 📝 Notes for Reviewers - Hero section still requires further refinement - This PR addresses part of the issue but not the final state --- # ✅ PR Checklist - [x] Code follows style guidelines - [x] Self-review completed - [x] Ready for incremental review
|
@VedantAnand17 is attempting to deploy a commit to the Subhadip Saha's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Overview
📄 Description
included package locks in gitignore
closes #58
🔗 Related Issue(s)
🛠️ Changes Made
🧪 Testing Details
npm run devwithout errors📸 Screenshots (if UI changes)
📝 Notes for Reviewers
✅ PR Checklist