Skip to content

fix: harden stale baselines and benchmark provenance - #32

Merged
styayur merged 2 commits into
mainfrom
fix/v1.1.1-stability
Oct 20, 2026
Merged

styayur merged 2 commits into
mainfrom
fix/v1.1.1-stability

Conversation

@styayur

@styayur styayur commented Oct 20, 2026

Copy link
Copy Markdown
Owner

Summary

Stability patch based on the published v1.1.0 release.

  • Matched baseline entries created under an older rule-semantics version now become Stale and require human review instead of remaining silently accepted.
  • Benchmark environment metadata now uses the benchmark project root for Git revision/worktree state rather than CodeForge's current working directory.
  • Clean benchmark worktrees are now recorded explicitly.
  • Versions and release notes are aligned to 1.1.1.

Why this is real

Auditing v1.1.0 found:

  1. assessment_from_entry() always returned Active, even when a matched entry's rule version was old.
  2. Benchmark environment discovery used the process cwd, so running codeforge benchmark /path/to/project could record CodeForge's commit instead of the target project's commit.

Compatibility

  • Baseline schema remains 1.
  • Existing baseline files remain readable; old-rule matches become human-review items.
  • Review and benchmark JSON changes are additive/correctional.
  • SARIF and Fleet formats are unchanged.
  • MSRV remains Rust 1.90.

Verification

  • Rust fmt, Clippy, workspace tests and release CLI build passed.
  • Added matched-stale baseline regression test.
  • Added target-root benchmark environment test.
  • Manual benchmark from another cwd recorded the target repository's commit and clean worktree state.
  • Frontend lint/typecheck/build and Markdown checks passed.

@styayur
styayur merged commit 4f06592 into main Oct 20, 2026
7 checks passed
@styayur
styayur deleted the fix/v1.1.1-stability branch October 20, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant