Repository navigation
Introduce AppHarbor's original beacon icon - #5
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb081c08b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <foreground android:drawable="@drawable/appharbor_beacon_foreground" /> | ||
| <monochrome android:drawable="@drawable/appharbor_beacon_monochrome" /> |
There was a problem hiding this comment.
When users open the app after seeing this new launcher icon, the main app bar still renders the inherited mascot through R.drawable.ic_launcher_monochrome (AppListScreen.kt:644), while the settings footer and TV rail use the old ic_launcher_foreground (SettingsScreen.kt:885 and TvHomeScreen.kt:492). Point these in-app brand surfaces at the new beacon drawables, or replace the old resources, so the rebrand does not leave the previous mascot prominently visible inside AppHarbor.
Useful? React with 👍 / 👎.
| android:fillColor="@android:color/transparent" | ||
| android:strokeColor="#244B56" | ||
| android:strokeWidth="1.5" | ||
| android:pathData="M54,47 m-35,0 a35,35 0,1 1,70 0 a35,35 0,1 1,-70 0" /> |
There was a problem hiding this comment.
On launchers that use a restrictive OEM mask, this foreground loses parts of the harbor ring and beacon rays because the artwork extends to roughly y=11.25 and x=18.25..89.75, outside the centered 66×66 safe zone (21..87) of the 108×108 layer. Android reserves the outer 18 dp for masking and effects and specifies that the logo must not exceed 66×66 dp (Android adaptive-icon guidance); scale or reposition the foreground so meaningful details are not clipped across launcher shapes.
Useful? React with 👍 / 👎.
| <foreground android:drawable="@drawable/appharbor_beacon_foreground" /> | ||
| <monochrome android:drawable="@drawable/appharbor_beacon_monochrome" /> |
There was a problem hiding this comment.
For the canary build on API 26+, changing the adaptive icon to the newly named drawable bypasses the source-set overrides in app/src/canary/res/drawable-*/ic_launcher_foreground.png, which carry the orange TEST banner. The merged canary APK therefore uses the same adaptive launcher artwork as release even though the two apps install alongside one another and the build configuration requires the test build to be unmistakably labelled; retain an overridable resource alias or add canary-specific versions of the new adaptive resources.
Useful? React with 👍 / 👎.
Introduce an original AppHarbor Beacon visual identity instead of carrying over the inherited app mascot.
Visual direction: sheltered harbor ring, luminous aqua H-shaped pier, amber discovery beacon. Assets are newly drawn for AppHarbor; upstream source attribution remains intact.
Note: Pre-Android-26 legacy density-specific PNG launcher resources are unchanged for now. Mainstream Android 8+ adaptive launcher resources will use the new icon. Verify in GitHub CI and on a real device before considering the icon finalized.