Repository navigation
Remove inherited upstream promotion and add AppHarbor support - #4
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cd6bd09b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (upstream.enabled) { | ||
| externalAppRepository.upsertAccount(upstream.copy(curated = false)) | ||
| } else { |
There was a problem hiding this comment.
Do not use enabled as the test for whether this is an untouched promotional entry. A user can enable the pre-seeded Victor-root account, complete discovery, and later disable it through the normal account toggle; it then remains curated == true but has enabled == false. On their first launch after this upgrade, the else branch deletes the account, all discovered apps, their settings, and scan history. Use evidence that the entry was never followed, such as lastScan == 0L and no dependent apps, and otherwise retain it as an ordinary account.
Useful? React with 👍 / 👎.
| RepoIcon( | ||
| iconUrl = account.iconUrl, | ||
| fallbackUrl = null, | ||
| name = account.label, |
There was a problem hiding this comment.
Apply this avatar change to the other account renderers as well. When an enabled Victor-root entry is retained as an ordinary source, this phone row now shows its GitHub avatar, but ExternalAccountDetailScreen.kt:222 and TvRepoListScreen.kt:672 still special-case the same key and display AppHarbor's launcher icon. Opening the account or viewing it on TV therefore continues to present an unrelated upstream maintainer as AppHarbor-branded, contrary to the migration's removal of that promotion.
Useful? React with 👍 / 👎.
| if (upstream.enabled) { | ||
| externalAppRepository.upsertAccount(upstream.copy(curated = false)) |
There was a problem hiding this comment.
Coordinate this update with creator discovery before marking the migration complete. Droidify.kt:105 concurrently resumes and schedules eligible enabled accounts during application startup, and a worker that read the old curated == true account passes that snapshot to rescanAccountNow; its final ExternalRefresher.kt:260 upsert writes the stale account back with only lastScan changed. If that scan finishes after this upsert, Victor-root returns to the curated picks while KEY_UPSTREAM_CURATED_CLEANUP_V1 remains set, so the migration never retries.
Useful? React with 👍 / 👎.
Product fixes
Compatibility
Retain the existing persisted preference key names,
ExternalAccount.OMNIFY_KEYas legacy lookup, and legacy source migration. No package rename, signing change, or source-provider rewrite. Upstream attribution remains in project lineage.Validation
Please run Android CI (
assembleDebug testDebugUnitTest) and review the startup migration carefully before merging. Device migration verification pending.