Repository navigation
fix(docs): say a change to a managed file must be a fix or feat to ship - #15
Merged
Merged
Conversation
The monthly Dependabot block merged as a chore, which release-please does not release, so sync kept pulling v0.3.1 with weekly. Document the trap, and let this commit be the release that carries the Dependabot change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
#14 moved the managed Dependabot block to monthly, but merged as a
chore. release-please does not releasechore, so no release followed andmake -C .devtools synckeeps pulling v0.3.1 with weekly. Consumers have to hand-apply it (see thecriticalissues in bimo-model, zero-trust, datapacks and tallyhopper).This adds the rule to the managed
CONTRIBUTING.mdblock so the next change doesn't repeat it, and, as afix, triggers the release that carries #14's Dependabot change tosync. Expect release-please to open a v0.3.2 PR after this merges; merging that is what ships it.Checklist
template:workflow, so it reaches projects at the release