Repository navigation
ci: open the release pull request as the release app - #16
Open
davidmoralesz wants to merge 1 commit into
Open
davidmoralesz wants to merge 1 commit into
davidmoralesz wants to merge 1 commit into
Conversation
A release pull request opened with GITHUB_TOKEN triggers no workflows, so its required checks never reported. The release job now passes the release app's client ID and key to the shared workflow, which opens the pull request as the app instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release pull request opened with
GITHUB_TOKENtriggers no workflows, so its required checks never report and each release needs the admin bypass or a close and reopen.The release job now passes
RELEASE_APP_CLIENT_IDandRELEASE_APP_PRIVATE_KEYto the shared release-please workflow (studiobimo/.github#66, live atv1), which mints a short-lived token and opens the release pull request, tag and Release as the app.Tested: local hooks pass, and both values are visible to this repository's Actions. Not tested: the mint step has not run yet; the first push to
mainafter this merges is its first run.