Repository navigation
fix(templates): pass the release app from the release-mod starter - #67
Merged
Merged
Conversation
A caller made from the starter opened its release pull request with GITHUB_TOKEN, so the required checks never ran on it. The starter now passes the release app's client ID and key, and lists installing the app among the steps before a first release. The README's caller example matches, and notes that a private repository needs its own copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A repository started from
workflow-templates/release-mod.ymlopened its release pull request withGITHUB_TOKEN, so the required checks never ran on it. This is the same gap the existing callers are closing by hand.release-mod.yml: the release job passesRELEASE_APP_CLIENT_IDandRELEASE_APP_PRIVATE_KEY; installing the app is now a listed step before a first release, including the Free-plan case where a private repository needs its own copies.README.md: the caller example passes them too, and the setup steps mention the private-repository case.Tested: local hooks pass (action-pins, actionlint, zizmor, prettier). Not tested: the starter is only ever copied, so nothing runs it here; the same lines are in the six open caller pull requests.