Repository navigation
chore(workflows): remove the pre-commit hooks and workflow - #63
Merged
Merged
Conversation
Every studiobimo project now runs its hooks with lefthook and checks commits with commitlint, so nothing calls these any more: - .devtools/check-conventional-commit.sh, replaced by commitlint - .pre-commit-hooks.yaml, replaced by lefthook/org.yml - ci-pre-commit.yml, replaced by ci-lint.yml The docs now show the lefthook remote at the floating v1 tag with a daily refetch, which is what the project template uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the three deprecated pieces that were kept only until every project had moved to lefthook and commitlint:
.devtools/check-conventional-commit.shand its test casespr-checks/lint.mjsin CI, each repo'scommit-msghook locally).pre-commit-hooks.yamllefthook/org.yml.github/workflows/ci-pre-commit.ymlci-lint.ymlDocs follow: the README's "Pre-commit hooks (deprecated)" section is gone, and the lefthook remote is now shown at the floating
v1tag withrefetch_frequency: 24h, which is whatproject-templateships. The README used to say never to usev1there.Is anything still using them?
No. On
mainofdatapacks,bimo-model,bimo-mod,zero-trust,tallyhopperandproject-template, a search forci-pre-commit,check-conventional-commitandpre-commit-hooks.yamlfinds nothing.Open Dependabot branches cut before the migrations still carry the old
lint.yml, but a pull request runs the workflow from its merge withmain, so they callci-lint.yml.Release
The type is
choreon purpose: removing a reusable workflow would otherwise read as a breaking change and semantic-release would cutv2, moving consumers offv1. Nothing calls the workflow, so nothing breaks. The files leavev1when the next release moves the tag.Tested
.devtools/test-hooks.sh: all pass, with the shell commit-checker cases removed and the commitlint cases kept.lefthook run pre-commit --all-files: Prettier, actionlint, zizmor, shellcheck, gitleaks and action-pins pass.