Repository navigation
fix(workflows): give both lint workflows the same check name - #57
Merged
Merged
Conversation
ci-pre-commit reported `lint / pre-commit` and ci-lint reports `lint / lefthook`, and checks-project requires the first. A repository moving to ci-lint therefore left its pull request waiting on a check that would never report. Both jobs are now named `hooks`, and both rulesets require `lint / hooks`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
rulesets/checks-project.jsonrequires a check calledlint / pre-commit. That name comes from the job insideci-pre-commit.yml.ci-lint.ymlnames its joblefthook, so a repository that switches reportslint / lefthookand its pull request waits forever on the old name. studiobimo/project-template PR 8 is stuck on exactly this.What
hooks, so the check islint / hookswhichever one a repository calls.checks-project.jsonandchecks-dotgithub.jsonrequirelint / hooks.After merging: apply the rulesets
The release moves
v1, and from then every repository reportslint / hookswhile its live ruleset still asks for the old name. Until the rulesets are applied, every pull request in the org waits on a check that will not come. Run this straight after the release:This PR itself has the same problem in reverse: it reports
lint / hookswhile this repo's live ruleset requireslint / lefthook, so it needs an admin bypass to merge.Tested
repo-settings.sh --checkwill show the two context changes.