Repository navigation
feat(devtools): move this repo to mise and lefthook's shared rules - #52
Merged
Merged
Conversation
davidmoralesz
added this pull request to stack #53
October 9, 2026 17:59
mise.toml and mise.lock replace install-hooks.sh, Homebrew and the devDependencies, so the hooks no longer skip a linter that is not installed. self-lint calls ci-lint, which runs the same lefthook.yml. commitlint.config.mjs becomes .commitlintrc.yaml, which ci-pr can read, so this repo's scopes are now enforced on the pull request too. pnpm is left with semantic-release only. ci-pre-commit and the pre-commit hooks are deprecated and stay until consumers move.
Replaces the hand-written rules in .commitlintrc.yaml with @commitlint/config-conventional plus this repo's scopes, pinned through mise next to the CLI. Also requires the lint / lefthook check in the ruleset, and documents how the tools in mise.toml are bumped by hand.
davidmoralesz
force-pushed
the
feat/mise-toolchain
branch
from
October 9, 2026 18:09
35bf040 to
7bc27f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Second of two, stacked on
feat/ci-lint.mise.tomlandmise.lockpin node, pnpm, lefthook, Prettier, commitlint, actionlint, zizmor, shellcheck and gitleaks. They replaceinstall-hooks.sh, Homebrew and the devDependencies.lefthook.ymlruns each tool throughmise exec, so the "skip if not installed" guards are gone, and it extendslefthook/org.ymlfor the push checks.self-lintcallsci-lint. TheworkflowsandPins and formattingjobs keep their names becauserulesets/checks-dotgithub.jsonrequires them.commitlint.config.mjsbecomes.commitlintrc.yaml, whichci-prreads, so this repo's scope list is now enforced on pull requests too. It no longer extendsconfig-conventional: no header length limit (Dependabot titles exceed 100) and no subject-case rule.package.jsonkeeps semantic-release only.ci-pre-commit.ymland.pre-commit-hooks.yamlare documented as deprecated; they stay until the consumers move.To know
mise.toml. Tool bumps are manual: edit,mise lock, commit.ci-lintdefaults to mise 2026.10.0. The lockfile here was written by 2026.10.6; if the older release cannot read it, this PR'slint / lefthookjob will say so.package.json) is obsolete after this.lint / lefthooktorulesets/checks-dotgithub.json.Tested
mise install --locked, thenlefthook run pre-commit --all-files: all six jobs pass.bash .devtools/test-hooks.sh: all pass.feat(nope): x, acceptsfeat(actions)!: x.release.ymlwith the trimmedpackage.json. It only runs onmain.