Repository navigation
feat(workflows): add ci-lint and the shared lefthook rules - #51
Merged
Merged
Conversation
davidmoralesz
added this pull request to stack #53
October 9, 2026 17:59
ci-lint is a reusable workflow that installs a repository's mise-pinned tools and runs its lefthook hook over every file. lefthook/org.yml gives consumers the branch-name and PR-size checks as a lefthook remote, from the scripts ci-pr already runs. Nothing calls either yet; the next change moves this repo onto both.
davidmoralesz
force-pushed
the
feat/ci-lint
branch
from
October 9, 2026 18:09
f04ab92 to
5ad5618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First of two. The org is standardizing on lefthook for hooks and mise for tool versions.
ci-lint.yml: reusable workflow. Installs the caller's mise-pinned tools (jdx/mise-action, SHA-pinned,--lockedwhen amise.lockexists) and runs its lefthook hook with--all-files. Replacesci-pre-commit.ymlfor repos that move.lefthook/org.ymland.lefthook/pre-push/: the branch-name and PR-size checks as a lefthook remote. The scripts are thin wrappers around the ones in.devtools/thatci-prruns, so there is still one implementation.Nothing calls either yet. The next PR (
feat/mise-toolchain) moves this repo onto both, and itsself-lintrun is the test ofci-lint.Tested
lefthook/org.ymlas a remote, from a scratch repository pointed at this branch: both jobs pass;BRANCH_NAME=Bad_Name lefthook run pre-push --job branch-namefails as it should.git pushof these branches. That found and fixed a bug: the wrappers forwarded git's pre-push arguments, so the remote name was checked as a branch name.check-action-pins.sh: clean.ci-lint.ymlon a runner. That happens in the next PR.