Repository navigation
docs: correct the plugin-ID note and the uninstall consequences - #8
Merged
Merged
Conversation
The 0.6.0 notes said the new plugin ID loses the stored configuration. osTicket 1.18 keys an installation by its install path and the config by the plugin's database id; replacing the folder under the same name keeps everything. The rollback section said the mapping table survives an uninstall; pre_uninstall drops both tables and deletes the webhooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two documentation errors, one of them in the published 0.6.0 notes:
idloses the stored configuration. In osTicket 1.18 an installed plugin is found byinstall_path, its config lives underplugin.<db-id>.instance.<n>; the manifestidis used only for PHAR signature checks (include/class.plugin.php). Replacing the folder under the same name keeps the settings.ost_trello_mapsurvives.pre_uninstall()deletes the webhooks and drops both tables (TrelloMap::uninstall(),TrelloBoardStore::uninstall()).After merge the v0.6.0 release notes are updated from the corrected CHANGELOG section.