Repository navigation
ci(build): make the package archive reproducible - #7
Merged
Merged
Conversation
Commit date for every file, sorted entries, no extra zip fields. Building the same commit twice now yields the same bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/build-zip.shproduced a different archive on every run (file times of the checkout, unsorted entries). Rebuilding a release changed its checksum, as happened with trello-sync v0.6.0 today.Now: file times set to the commit date, entries sorted,
TZ=UTC zip -X; the trello-sync Python fallback writes fixedZipInfodates as well. Same approach as the subticket and api-endpoints builds.Checked in Alpine: two builds of the same commit with different file times give identical SHA-256 (trello-sync: zip and Python path).