Skip to content

fix(ui): tick and menu on views opened by ticket number (v0.2.1) - #3

Merged
studio-prisma merged 2 commits into
mainfrom
fix/ui-number-link
Nov 8, 2026
Merged

studio-prisma merged 2 commits into
mainfrom
fix/ui-number-link

Conversation

@studio-prisma

Copy link
Copy Markdown
Owner

What changes

Opening a ticket view by number (scp/tickets.php?number=…) skipped the agent-panel script: FeedbackUi only looked at $_GET['id']. It now resolves the ticket the way scp/tickets.php does ($_REQUEST['id'], else $_REQUEST['number'], both validated). Found in the live test of 0.2.0.

Type

  • Bug fix

Security impact

  • No security-relevant surface touched (same permission check checkStaffPerm, only another way to find the ticket; the number is validated before lookup)

Verification

  • php tests/unit.php: 155/155
  • E2E 9-decide.spec.js UI tests 5/5, new: view opened by ?number= shows tick and menu entry

@studio-prisma
studio-prisma merged commit b0d4e2c into main Nov 8, 2026
9 checks passed
@studio-prisma
studio-prisma deleted the fix/ui-number-link branch November 8, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant