Skip to content

feat: closing statuses that never ask, note when the question is sent (v0.1.1) - #1

Merged
studio-prisma merged 2 commits into
mainfrom
feat/0.1.1
Nov 8, 2026
Merged

studio-prisma merged 2 commits into
mainfrom
feat/0.1.1

Conversation

@studio-prisma

Copy link
Copy Markdown
Owner

What changes

  • Closing statuses that never ask: new setting "Never ask for → Closing statuses". Closing with such a status (e.g. "Duplicate", "Spam", "Hinfällig") asks nobody and leaves no row; a later close with another status still asks. Preselected by name.
  • Note at the ticket when asked (own mail mode): short (recipient, scale, valid until; default), short plus the mail as sent with its rating links, or none. Emojis are stripped from the copied mail (3-byte utf8), the button words stay.
  • Note on a failed send, always.
  • INSTALL: after creating the instance, open it again and check the checkboxes (osTicket 1.18 doesn't store checkbox defaults on the first save). New settings apply their built-in default until the instance is saved once.
  • Version 0.1.1, CHANGELOG.

Type

  • Bug fix
  • New feature
  • Documentation
  • CI / tooling
  • Refactor (no behaviour change)

Security impact

  • Changes the token or its validation (FeedbackToken)
  • Changes the public click page, CSRF or rate limits (FeedbackPage)
  • Changes what is stored or how long (FeedbackStore)
  • Changes who gets asked (FeedbackRules, FeedbackTrigger)
  • No security-relevant surface touched

Who gets asked: only narrower (one more exclusion). The "with the mail" note copies the customer's rating links into an internal note; every agent who can open the ticket can then rate. Off by default (default note has no links), documented in SECURITY.md and README.

Verification

  • php tests/unit.php passes (PHP version: 8.4): 142/142
  • npx playwright test passes against dev/up.sh: 58/58, new spec 8-status-note.spec.js
  • No hardcoded hostnames, credentials or absolute paths added

A closed status like "Duplicate" or "Hinfällig" means nothing was done;
closing with one of the excluded statuses now never asks. Preselected by
name. In mail mode the ticket gets an internal note after the question
went out: short (recipient, scale, valid until), with the mail as sent
including its rating links, or none. A failed send always gets a note,
so nobody assumes the customer was asked.

INSTALL: osTicket 1.18 doesn't store checkbox defaults when an instance
is created; open it again and check the boxes.
@studio-prisma
studio-prisma merged commit 36874a5 into main Nov 8, 2026
9 checks passed
@studio-prisma
studio-prisma deleted the feat/0.1.1 branch November 8, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant