Repository navigation
feat: closing statuses that never ask, note when the question is sent (v0.1.1) - #1
Merged
Merged
Conversation
A closed status like "Duplicate" or "Hinfällig" means nothing was done; closing with one of the excluded statuses now never asks. Preselected by name. In mail mode the ticket gets an internal note after the question went out: short (recipient, scale, valid until), with the mail as sent including its rating links, or none. A failed send always gets a note, so nobody assumes the customer was asked. INSTALL: osTicket 1.18 doesn't store checkbox defaults when an instance is created; open it again and check the boxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Type
Security impact
FeedbackToken)FeedbackPage)FeedbackStore)FeedbackRules,FeedbackTrigger)Who gets asked: only narrower (one more exclusion). The "with the mail" note copies the customer's rating links into an internal note; every agent who can open the ticket can then rate. Off by default (default note has no links), documented in SECURITY.md and README.
Verification
php tests/unit.phppasses (PHP version: 8.4): 142/142npx playwright testpasses againstdev/up.sh: 58/58, new spec8-status-note.spec.js