Skip to content

feat(update): feedback flag for the Feedback plugin (v2.9.0) - #18

Merged
studio-prisma merged 2 commits into
mainfrom
feat/feedback-flag
Nov 8, 2026
Merged

studio-prisma merged 2 commits into
mainfrom
feat/feedback-flag

Conversation

@studio-prisma

Copy link
Copy Markdown
Owner

What changes

PATCH /api/tickets-update.php/{number}.json accepts an optional boolean feedback next to statusId. While the status changes, the controller sets $_POST['feedback_ask'] to 1/0 and restores $_POST afterwards. This is the same bridge the controller already uses for Markdown Support ($_POST['format']). The Feedback plugin 0.2 reads it to ask or skip the customer's satisfaction question.

  • Left out: nothing is set, behaviour unchanged.
  • Invalid value: 400 before the first change (validated next to subject).
  • Version 2.9.0, CHANGELOG, OpenAPI (UpdateTicketRequest.feedback), README.

Security impact

The flag only reaches a plugin that reads it; it can't change permissions. The Feedback plugin treats it as "confirm or suppress", never as a way to widen its rules.

Verification

  • PHPUnit: 324 tests OK (13 new in UpdateTicketFeedbackFlagTest: true/false/absent, restore, invalid value refused before any change, accepted spellings).

…hanges

PATCH tickets-update accepts an optional boolean `feedback` next to
statusId. While the status changes it is set as $_POST['feedback_ask']
(1/0), the same bridge Markdown Support uses for $_POST['format'], and
restored afterwards. The Feedback plugin 0.2 reads it to ask or skip the
customer's satisfaction question. Invalid values are refused with 400
before the first change. Version 2.9.0.
@studio-prisma
studio-prisma merged commit f81b030 into main Nov 8, 2026
8 checks passed
@studio-prisma
studio-prisma deleted the feat/feedback-flag branch November 8, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant