Repository navigation
feat(update): feedback flag for the Feedback plugin (v2.9.0) - #18
Merged
Merged
Conversation
…hanges PATCH tickets-update accepts an optional boolean `feedback` next to statusId. While the status changes it is set as $_POST['feedback_ask'] (1/0), the same bridge Markdown Support uses for $_POST['format'], and restored afterwards. The Feedback plugin 0.2 reads it to ask or skip the customer's satisfaction question. Invalid values are refused with 400 before the first change. Version 2.9.0.
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
PATCH /api/tickets-update.php/{number}.jsonaccepts an optional booleanfeedbacknext tostatusId. While the status changes, the controller sets$_POST['feedback_ask']to1/0and restores$_POSTafterwards. This is the same bridge the controller already uses for Markdown Support ($_POST['format']). The Feedback plugin 0.2 reads it to ask or skip the customer's satisfaction question.subject).UpdateTicketRequest.feedback), README.Security impact
The flag only reaches a plugin that reads it; it can't change permissions. The Feedback plugin treats it as "confirm or suppress", never as a way to widen its rules.
Verification
UpdateTicketFeedbackFlagTest: true/false/absent, restore, invalid value refused before any change, accepted spellings).