Repository navigation
Conversation
No workflow run was created for this pull request when it was opened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stubbi
approved these changes
Oct 11, 2026
stubbi
left a comment
Owner
There was a problem hiding this comment.
Thanks @jtatum - good catch: in watchNamespaces mode managerRules render as namespaced Roles, where a namespaces rule is inert because Namespace is cluster-scoped. Moving it to clusterScopedRules (narrowed with resourceNames) is correct, and the RBAC-enforcing envtest is exactly the right kind of test. Merging into #618's branch so it ships together with the fixOwnership change; #618's CI covers it against main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
watchNamespacesmode, #618 placesget namespacesin tenant Roles. Namespace objects are cluster-scoped, so those grants cannot authorize the Pod Security label lookup. The controller then retains the ownership helper default, potentially producing a pod rejected by restricted admission.Move Namespace reads into the chart's existing cluster-scoped rule set and ClusterRoleBinding. In namespaced mode, constrain
resourceNamesto the configured watched namespaces. Cluster-wide mode permits reading any Namespace. Neither mode gains Namespace list/watch/write permissions.This PR targets
fix/data-owner-pss-awareas a focused follow-up to #618. It can be retargeted/rebased onto main after that PR merges. The separate namespace-lookup failure handling review on #618 remains relevant; this change fixes the chart permission grant.Validation:
make test,make lint, and both Helm RBAC guard scripts pass. CI installs Helm for the authorization test.