fix: resolve DTS build failure and prettier formatting by polaz · Pull Request #34 · structured-id/opaque

polaz · 2026-04-03T16:09:40Z

Summary

Fix prettier formatting in src/testing/performance.ts (extra parens in void expressions)
Add ignoreDeprecations: "6.0" to tsconfig.json — fixes TypeScript 6 baseUrl deprecation that broke DTS build
Update @types/node ^25.5.1 → ^25.5.2
Fix npm publish workflow:
- Remove registry-url from setup-node (was overriding OIDC with invalid GITHUB_TOKEN)
- Add idempotency check using package.json version (not git tag)
- Validate tag matches package.json before publish
- Upgrade setup-node v4 → v6, node 22 → 24

Auth: npm OIDC trusted publishing (no tokens needed).

Test plan

Closes #32
Closes #35

codecov · 2026-04-03T16:10:22Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/testing/performance.ts	0.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

- Fix prettier formatting in src/testing/performance.ts (extra parens in void expressions) - Add ignoreDeprecations: "6.0" to tsconfig.json for TypeScript 6 baseUrl deprecation - Update @types/node ^25.5.1 → ^25.5.2 Closes #32

Copilot

Pull request overview

Updates build/publish configuration and minor formatting to resolve CI failures introduced by TypeScript 6 and packaging gaps, plus a small dependency bump.

Changes:

Add ignoreDeprecations: "6.0" to unblock TypeScript 6 DTS build warnings/errors.
Fix Prettier formatting in src/testing/performance.ts for void + regex expressions.
Update @types/node to ^25.5.2 and include wasm/ in the published npm package files.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File	Description
`yarn.lock`	Locks `@types/node` to 25.5.2 to match the dependency update.
`tsconfig.json`	Adds `ignoreDeprecations: "6.0"` to address TS 6 deprecation impacting DTS builds.
`src/testing/performance.ts`	Removes unnecessary parentheses in `void` expressions to satisfy Prettier.
`package.json`	Publishes `wasm/` alongside `dist/` and bumps `@types/node` version.

polaz · 2026-04-03T16:16:13Z

@coderabbitai full review

Copilot

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

package.json

OIDC trusted publishing only works for already-published packages. First publish requires explicit npm automation token. - Add NODE_AUTH_TOKEN env var pointing to NPM_TOKEN secret - Keep --provenance for OIDC signing (separate from auth) - Requires NPM_TOKEN secret in "release" environment Closes #35

- Upgrade actions/setup-node v4 → v6, node 22 → 24 - Use yarn npm publish instead of npm publish - Add idempotency check (skip if version already published) - Use NPM_CONFIG_PROVENANCE env var instead of --provenance flag Closes #35

npm trusted publishing authenticates via GitHub Actions OIDC identity. No secret tokens needed — configured at npmjs.com package settings. Closes #35

actions/setup-node with registry-url creates .npmrc with NODE_AUTH_TOKEN=${GITHUB_TOKEN} which overrides OIDC auth. Without registry-url, npm falls back to OIDC identity for auth.

Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

.github/workflows/publish.yml

Use package.json version (what npm publish uses) instead of git tag for idempotency check. Fail fast if tag and package.json diverge.

polaz · 2026-04-03T17:03:41Z

@coderabbitai resume and full review

Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

src/testing/performance.ts

Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

.github/workflows/publish.yml

Upgrade all CI workflows to Node 24 + actions/setup-node@v6 to match publish.yml. Update test matrix from [20, 22] to [22, 24].

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 3, 2026 16:09

Copilot started reviewing on behalf of polaz April 3, 2026 16:10 View session

chore: update dependencies and fix CI issues

c589eec

- Fix prettier formatting in src/testing/performance.ts (extra parens in void expressions) - Add ignoreDeprecations: "6.0" to tsconfig.json for TypeScript 6 baseUrl deprecation - Update @types/node ^25.5.1 → ^25.5.2 Closes #32

polaz force-pushed the chore/#32-update-deps-fix-ci branch from cdef0e6 to c589eec Compare April 3, 2026 16:11

Copilot AI reviewed Apr 3, 2026

View reviewed changes

polaz changed the title ~~chore: update dependencies and fix CI issues~~ fix: resolve DTS build failure and prettier formatting Apr 3, 2026

polaz requested a review from Copilot April 3, 2026 16:15

Copilot started reviewing on behalf of polaz April 3, 2026 16:16 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

package.json Show resolved Hide resolved

polaz added 3 commits April 3, 2026 19:18

fix: align publish.yml with gitlab-mcp pattern

d1ff572

- Upgrade actions/setup-node v4 → v6, node 22 → 24 - Use yarn npm publish instead of npm publish - Add idempotency check (skip if version already published) - Use NPM_CONFIG_PROVENANCE env var instead of --provenance flag Closes #35

fix: use OIDC trusted publishing, remove NPM_TOKEN

aac7c02

npm trusted publishing authenticates via GitHub Actions OIDC identity. No secret tokens needed — configured at npmjs.com package settings. Closes #35

polaz mentioned this pull request Apr 3, 2026

fix: npm publish fails with E404 — setup-node registry-url breaks OIDC auth #35

Closed

fix: remove registry-url that breaks OIDC trusted publishing

96a08a5

actions/setup-node with registry-url creates .npmrc with NODE_AUTH_TOKEN=${GITHUB_TOKEN} which overrides OIDC auth. Without registry-url, npm falls back to OIDC identity for auth.

polaz requested a review from Copilot April 3, 2026 16:51

Copilot started reviewing on behalf of polaz April 3, 2026 16:51 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

.github/workflows/publish.yml Outdated Show resolved Hide resolved

.github/workflows/publish.yml Show resolved Hide resolved

fix: validate package.json version matches release tag before publish

f96633e

Use package.json version (what npm publish uses) instead of git tag for idempotency check. Fail fast if tag and package.json diverge.

polaz requested a review from Copilot April 3, 2026 17:03

Copilot started reviewing on behalf of polaz April 3, 2026 17:04 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

src/testing/performance.ts Outdated Show resolved Hide resolved

fix: add missing void prefix to digit regex check for consistency

272ba57

polaz requested a review from Copilot April 3, 2026 17:09

Copilot started reviewing on behalf of polaz April 3, 2026 17:10 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

.github/workflows/publish.yml Show resolved Hide resolved

fix: align Node.js and setup-node versions across all workflows

ef52c9a

Upgrade all CI workflows to Node 24 + actions/setup-node@v6 to match publish.yml. Update test matrix from [20, 22] to [22, 24].

polaz requested a review from Copilot April 3, 2026 17:39

Copilot started reviewing on behalf of polaz April 3, 2026 17:39 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

polaz merged commit 4de0dfa into main Apr 3, 2026
14 of 15 checks passed

polaz deleted the chore/#32-update-deps-fix-ci branch April 3, 2026 17:49

sid-release-bot bot mentioned this pull request Apr 3, 2026

chore(main): release 1.0.4 #36

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve DTS build failure and prettier formatting#34

fix: resolve DTS build failure and prettier formatting#34
polaz merged 8 commits intomainfrom
chore/#32-update-deps-fix-ci

polaz commented Apr 3, 2026 •

edited

Loading

Uh oh!

codecov bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

polaz commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

polaz commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

polaz commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

codecov bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

polaz commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

polaz commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

polaz commented Apr 3, 2026 •

edited

Loading

codecov bot commented Apr 3, 2026 •

edited

Loading