fix(assert): prevent stack overflow on cyclic data structures in EqualExportedValues - #1939
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix(assert): prevent stack overflow on cyclic data structures in EqualExportedValues#1939AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…lExportedValues When comparing struct values with self-referential pointers using EqualExportedValues, copyExportedFields would recurse infinitely causing a stack overflow. Fixed by tracking visited pointers in a seen map and breaking cycles by returning nil for already-seen pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
assert.EqualExportedValuespanics with a stack overflow when comparing structs that contain self-referential pointers (cyclic data structures). ThecopyExportedFieldsfunction recurses infinitely following the cycle until the goroutine stack is exhausted.Example
Fix
Added cycle detection to
copyExportedFieldsby tracking visited pointers in amap[uintptr]struct{}. When a pointer is revisited, the function returnsnilinstead of recursing infinitely.Changes
assert/assertions.go: ModifiedcopyExportedFieldsto accept aseenmap for cycle detectionassert/assertions_test.go: Updated test to use new helper functionTesting
All existing tests pass. The fix prevents stack overflow while maintaining correct behavior for non-cyclic structures.