[DXP-1512] StreamX Platform adjustments - #7
Draft
kamilchociej wants to merge 19 commits into
Draft
Conversation
# Conflicts: # deployment.yaml # scripts/run-pim-k8s.sh # scripts/run-proxy.sh # scripts/run-websight-k8s.sh
kamilchociej
marked this pull request as ready for review
January 17, 2025 10:32
kamilchociej
marked this pull request as draft
January 17, 2025 10:36
| @@ -0,0 +1,5 @@ | |||
| export STREAMX_TOKEN_PIM= | |||
Contributor
There was a problem hiding this comment.
local should be default from .env file, that is overridden by sh script for cloud deployment.
https://quarkus.io/guides/images/config-sources.png
| environment: | ||
| # local test domain, see readme | ||
| STREAMX_BLUEPRINTS_SITEMAP-GENERATOR-PROCESSING-SERVICE_BASE-URL: "http://puresight.127.0.0.1.nip.io" | ||
| STREAMX_BLUEPRINTS_SITEMAP-GENERATOR-PROCESSING-SERVICE_BASE-URL: "http://puresight.${STREAMX_INGRESS_IP}.nip.io" |
Contributor
There was a problem hiding this comment.
Maybe we could configure whole domains, so that many people can deploy on the single cluster in multiple namespaces?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Type of the Changes
🛠 Changes being made
StreamX Platform deployment preparation
✅ Checklist