Redesign Onboarding #5687
Open
Redesign Onboarding #5687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelinewu
reviewed
Dec 15, 2025
| const showOnboarding = useRealmObject(OnboardingV2Service.state).showOnboarding; | ||
|
|
||
| useEffect(() => { | ||
| // OnboardingV2Service.actions.showOnboardingIfNecessary(); |
Contributor
There was a problem hiding this comment.
Should this one be used instead?
Contributor
Author
There was a problem hiding this comment.
yea it should be used in production, was just switched over for testing
|
|
||
| // Set up temporary sources | ||
| useEffect(() => { | ||
| DefaultHardwareService.createTemporarySources(); |
Contributor
There was a problem hiding this comment.
Small thing since I know if this is modeled off of the hardware setup but I was wondering if it would be worthwhile to add some handling/logging if there is an error creating temporary sources just for debugging purposes
Contributor
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…eamlabs-obs into sb_ab_onboarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.