Test/mg/major refactor#64
Merged
Merged
Conversation
- fix mutable default arg bug in EventQueue.close() - replace Iterator with Generator in cli_errors return type - add .kiro library-development skill with project map reference - rewrite README and AGENTS.md for clarity
- Establish a thin-translator doctrine: assert on wiring, error types, and emitted-event/manifest shape through public seams — never on private members, strands/Pydantic internals, mock calls, or message text - Fake strands only at our own resolver seams (resolve_model / mcp) with hand-written fakes and real Agent objects; keep every test deterministic (no network, model calls, MCP subprocesses, or sleeps) - Restructure tests to mirror pipeline stages (parse, schema, resolve, runtime, pipeline, property, contract), weighted toward resolver wiring, with builders over fixture sprawl - Pin the public event/manifest shape with a single reviewed contract snapshot instead of scattered exact event-count assertions - Close targeted gaps in owned logic: multi-agent result extraction, tool-name sanitizer recovery, and the session-manager infra/session split
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the test suite around a behaviour-driven, slim-by-default strategy and documents it as the project's testing doctrine.
Adds
.kiro/skills/library-testing/SKILL.md— the authoritative doctrine that defines what is worth testing, what is not, and how. Establishes the mental model, includesreferences/test-patterns.mdwith copy-paste templates.Implements the doctrine across the full suite:
resolve_model/resolve_mcp_server/resolve_mcp_client) using hand-writtenFakeModel/FakeMCPServer/FakeMCPClient; all tests are deterministic (no network, no model calls, no MCP subprocesses, no sleeps).parse/,schema/,resolve/,runtime/,pipeline/,property/,contract/), weighted toward resolver wiring, withfactories.pybuilders over fixture sprawl.StreamEvent/SessionManifestshape with a single reviewed contract snapshot (contract/test_shape.py) instead of scattered event-count assertions.runtime/test_result_extraction.py), tool-name sanitizer recovery paths (parametrizedBeforeToolCallEvent+AfterModelCallEventLayer-1 test), and the session-manager infra/session split contract (resolve/test_session_manager.py).just checkclean.Related Issues
N/A
Type of Change
YAML / API Impact
None. No changes to the config schema or public Python API.
Testing
How have you tested the change?
uv run just check(lint + type check)uv run just testfor overall testingexamples/still workChecklist