Skip to content

chore(ci): seed minimal GitHub Actions workflow#9

Merged
petterlindstrom79 merged 1 commit intomainfrom
chore/seed-ci-workflow
Apr 17, 2026
Merged

chore(ci): seed minimal GitHub Actions workflow#9
petterlindstrom79 merged 1 commit intomainfrom
chore/seed-ci-workflow

Conversation

@petterlindstrom79
Copy link
Copy Markdown
Member

Seeds a workflow file into main so that `pull_request` triggers on future PRs fire reliably. Enables the Phase B+C PR (#8) to run CI.

Why this exists as a separate small PR

Today there is no workflow file on main. When #8 was opened, GitHub didn't auto-trigger its workflow because introducing a workflow in a PR against a base that has never had one leaves the trigger in an ambiguous state. Seeding this tiny workflow first, then rebasing/merging #8 on top, gets #8's richer CI running.

What this workflow does

Just `npm ci` + `npm run build` (mcp-server then apps/api) — the only steps main's current package.json has scripts for.

What this PR does NOT include

  • The `typecheck`, `test`, `lint:no-bare-catch`, `lint:ssrf-inventory` scripts — those arrive with Phase B + C: P0/P1 fixes from Session 0 review #8. Adding their steps now would fail because the scripts don't exist on main.
  • Any source code changes. Workflow file only.

After this merges, #8 will be updated to merge main back in (resolves conflicts), and its fuller ci.yml will land when #8 merges.

🤖 Generated with Claude Code

This seeds a workflow file into main so that pull_request triggers on
future PRs fire reliably. The Phase B+C PR (adds F-0-001..F-0-020)
contains the real check steps — typecheck, vitest, lint:no-bare-catch,
and the SSRF inventory guard — but those scripts don't exist on main
yet, so running them here would fail.

For now the seed just runs the build (mcp-server, then apps/api) which
main has the infrastructure for today. The real CI steps land with the
Phase B+C merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@petterlindstrom79 petterlindstrom79 merged commit 21b785d into main Apr 17, 2026
1 check passed
@petterlindstrom79 petterlindstrom79 deleted the chore/seed-ci-workflow branch April 17, 2026 14:22
petterlindstrom79 added a commit that referenced this pull request Apr 17, 2026
…kage import

apps/api/src/routes/mcp.ts imports from the `strale-mcp/tools`
workspace package, which resolves to packages/mcp-server/dist/tools.js
(+ .d.ts). The Dockerfile builds the MCP server before the API for
exactly this reason — without it tsc --noEmit can't find the module
and fails with TS2307.

The seed workflow (PR #9, now on main) had this step; it was dropped
by accident when Phase C's richer ci.yml was written. Restoring it
before typecheck; leaving it before `npm test` as well since tests
also type-check the imports transitively.

CI failure pre-fix:
  src/routes/mcp.ts(31,8): error TS2307: Cannot find module 'strale-mcp/tools'
  src/routes/mcp.ts(81,50): error TS7006: Parameter 'c' implicitly has an 'any' type.
  src/routes/mcp.ts(82,53): error TS7006: Parameter 's' implicitly has an 'any' type.

The two TS7006 errors cascade from the TS2307 (caps/sols become any[]
when the import can't be resolved); they disappear once the build step
is in place.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant