Skip to content

ACM-37360 Remove unneeded hook dependency [release-2.17]#6494

Open
KevinFCormier wants to merge 1 commit into
stolostron:release-2.17from
KevinFCormier:ACM-37360-fix-install-submariner-hang
Open

ACM-37360 Remove unneeded hook dependency [release-2.17]#6494
KevinFCormier wants to merge 1 commit into
stolostron:release-2.17from
KevinFCormier:ACM-37360-fix-install-submariner-hang

Conversation

@KevinFCormier

Copy link
Copy Markdown
Contributor

📝 Summary

Ticket Summary (Title):
ACM UI Hangs when click install submariner addon when mce managed cluster are imported to acm

Ticket Link:
https://redhat.atlassian.net/browse/ACM-37360

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

Signed-off-by: Kevin Cormier <kcormier@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 01c2cb43-f991-4e31-9cf2-7af75b786860

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@KevinFCormier KevinFCormier changed the title ACM-37360 Remove unneeded hook dependency ACM-37360 Remove unneeded hook dependency [release-2.17] Jul 16, 2026
@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/hold for 2.17.1 z-stream

@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/test unit-tests-sonarcloud

@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/cc @oksanabaza

@openshift-ci
openshift-ci Bot requested a review from oksanabaza July 16, 2026 19:35
@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/test unit-tests-sonarcloud

2 similar comments
@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/test unit-tests-sonarcloud

@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/test unit-tests-sonarcloud

@sonarqubecloud

Copy link
Copy Markdown

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, oksanabaza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,oksanabaza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm label Jul 20, 2026
@evelinec

Copy link
Copy Markdown

Anything else for this PR? Ready to merge? Thanks

@KevinFCormier

Copy link
Copy Markdown
Contributor Author

@evelinec All z-streams are by default closed to bug fixes (but open to CVEs) until a specific release is scheduled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants