Use dicts for clearer truth tables and test vectors#87
Draft
infinitymdm wants to merge 3 commits intostineje:mainfrom
Draft
Use dicts for clearer truth tables and test vectors#87infinitymdm wants to merge 3 commits intostineje:mainfrom
infinitymdm wants to merge 3 commits intostineje:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The major change in this PR is to test vector & truth table generation. Previously these were given as lists of lists in the form
With this PR truth tables and test vectors are both given as dictionary objects instead, so that pin labels are explicit instead of implied by operand order.
The second change implemented here is related to sequential cell test vector generation. The previous test vector generation code would create "nonsense" states (discovery by @AndersonHsieh0330) where the internal state did not match the initial output state. This PR improves on that by filtering out those nonsense states. (Though I'm not 100% confident that this is correct yet, which is why this is currently a draft.)
Finally, This PR removes some long-unused code from Parser.py and makes minor fixes to debug SPICE output.