fix: support Edge browser in Dramaturg extension#907
Merged
Conversation
- Block edge:// URLs in isAttachableUrl and attachToTab (same as chrome://) - Update error message to say "browser restricts" instead of "Chrome restricts" - Add edge:// to isInternalUrl and handleRecord in Toolbar - Add edge: protocol handling in getTabLabel for correct tab label display - Update manifest description to say "browser side panel" Closes #901 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edge://URLs inisAttachableUrlandattachToTab(same treatment aschrome://)edge://guard inisInternalUrlandhandleRecordin Toolbaredge:protocol handling ingetTabLabelsoedge://settingsetc. display correctly in the tab dropdownNo permission or manifest structure changes needed — Edge is Chromium-based and uses the same
chrome-extension://URL scheme, so existing extension filtering already works for Edge extension pages.Test plan
edge://extensions→ extension appearsedge://tab active, attach button is disabled / shows correct erroredge://tabs display with correct label in the tab dropdowngoto edge://...emittedCloses #901
🤖 Generated with Claude Code